Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go): bump go 1.20 to 1.21 #1654

Merged
merged 6 commits into from
Feb 15, 2024
Merged

feat(go): bump go 1.20 to 1.21 #1654

merged 6 commits into from
Feb 15, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Feb 13, 2024

As Go 1.22 has been released, we can update our version from 1.20 to 1.21.
In the process, I've also updated the slog import to use the one from the standard library.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@gfanton gfanton requested review from moul, a team, jaekwon, piux2 and zivkovicmilos as code owners February 13, 2024 13:41
@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Feb 13, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a2b5f29) 56.17% compared to head (2f02ed7) 56.19%.
Report is 2 commits behind head on master.

Files Patch % Lines
gno.land/pkg/log/zap.go 0.00% 1 Missing ⚠️
gnovm/stdlibs/std/native.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1654      +/-   ##
==========================================
+ Coverage   56.17%   56.19%   +0.02%     
==========================================
  Files         439      447       +8     
  Lines       66242    67070     +828     
==========================================
+ Hits        37209    37693     +484     
- Misses      26143    26447     +304     
- Partials     2890     2930      +40
Flag Coverage Δ
go-1.22.x ∅ <ø> (?)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul
Copy link
Member

moul commented Feb 13, 2024

If there are any features from go1.21 that should be implemented, please feel free to suggest them in an issue.

@thehowl
Copy link
Member

thehowl commented Feb 13, 2024

can you (have you) also updated any uses of x/exp/slices?

@gfanton
Copy link
Member Author

gfanton commented Feb 13, 2024 •
edited
Loading

can you (have you) also updated any uses of x/exp/slices?

good catch, I will update this one too and check for all other x libs

after some searchs, it seems we are not using x/exp/slices anywhere

@gfanton
chore: lint
b01e63c 
Signed-off-by: gfanton <[email protected]>
@zivkovicmilos zivkovicmilos mentioned this pull request Feb 14, 2024
Open
zivkovicmilos
zivkovicmilos approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

Thank you for bumping the loggers as well, it was a pain with 1.20 🙏

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 15, 2024
thehowl
thehowl approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the version in a few more places you missed. should be all good, merging after CI :)

@gfanton
Copy link
Member Author

gfanton commented Feb 15, 2024

@thehowl thanks ! 🙌

@thehowl thehowl merged commit f233d52 into gnolang:master Feb 15, 2024
198 of 199 checks passed
@michelleellen michelleellen mentioned this pull request Feb 24, 2024
Open
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
@gfanton @thehowl @leohhhn
feat(go): bump go 1.20 to 1.21 (gnolang#1654)
5e598d6 
As Go `1.22` has been released, we can update our version from `1.20` to
`1.21`.
In the process, I've also updated the `slog` import to use the one from
the standard library.


---------

Signed-off-by: gfanton <[email protected]>
Co-authored-by: Morgan Bazalgette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@albttx albttx albttx approved these changes

@thehowl thehowl thehowl approved these changes

@moul moul moul approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon

@piux2 piux2 Awaiting requested review from piux2

@harry-hov harry-hov Awaiting requested review from harry-hov

Assignees

@gfanton gfanton

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
💪 Bounties & Worx
Status: Done
🚀 The Launch [DEPRECATED]
Status: No status
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gfanton @moul @thehowl @albttx @zivkovicmilos